Skip to content

Add Makefile for developer workflow#1

Merged
jaeyeom merged 2 commits into
mainfrom
add-makefile
May 7, 2026
Merged

Add Makefile for developer workflow#1
jaeyeom merged 2 commits into
mainfrom
add-makefile

Conversation

@jaeyeom
Copy link
Copy Markdown
Contributor

@jaeyeom jaeyeom commented Apr 6, 2026

Summary

  • Adds a Makefile wrapping existing npm scripts for consistent make usage locally and in CI
  • Targets: all, check, format, check-format, lint, fix, typecheck, test, test-unit, test-integration, test-e2e, test-all, build, clean, coverage
  • Parallel-safe: fix depends on format to prevent concurrent file writes; read-only targets are safe with make -j

Test plan

  • make -n all produces correct command sequence: format → fix → test → build
  • make -n check produces correct command sequence: check-format → lint → typecheck → test → build
  • Pre-commit hook passes (runs make -j check)

jaeyeom added 2 commits April 5, 2026 22:22
Wraps existing npm scripts with Make targets for consistent local and
CI usage. Includes format, lint, fix, typecheck, test, build, clean,
and coverage targets with parallel-safe dependency ordering.
fix already depends on format, so listing both caused format to run
twice. Now all: fix test build gets the same result in one pass.
@jaeyeom jaeyeom requested a review from serithemage April 6, 2026 07:15
@jaeyeom jaeyeom self-assigned this Apr 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

This PR has been inactive for 30 days. It will be closed in 14 days unless there is new activity.

@github-actions github-actions Bot added the stale label May 7, 2026
@jaeyeom jaeyeom merged commit adcc7bb into main May 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant